feat: Implement get account proof endpoint #556
+455
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
changed the title
tomyrd
reviewed
Oct 23, 2024
bobbinth
reviewed
Oct 28, 2024
crates/rust-client/src/rpc/mod.rs
Outdated
Comment on lines
138
to
148
| /// Represents a proof of existence of an account's state at a specific block number. | ||
| pub struct AccountProof { | ||
| /// Account ID. | ||
| account_id: AccountId, | ||
| /// Authentication path from the `account_root` of the block header to the account. | ||
| merkle_proof: MerklePath, | ||
| /// Account hash for the current state. | ||
| account_hash: Digest, | ||
| /// State headers of public accounts. | ||
| state_headers: Option<(AccountHeader, AccountStorageHeader, Option<AccountCode>)>, | ||
| } |
There was a problem hiding this comment.
Should this be defined in the domain module?
tomyrd
approved these changes
Oct 28, 2024
SantiagoPittella
approved these changes
Nov 1, 2024
| @@ -3,6 +3,7 @@ | |||
| ## 0.6.0 (TBD) | |||
|
|
|||
| * Allow to set expiration delta for `TransactionRequest` (#553). | |||
| * Implemented `GetAccountProof` endpoint (#556) | |||
There was a problem hiding this comment.
nit:
Suggested change
| * Implemented `GetAccountProof` endpoint (#556) | |
| * Implemented `GetAccountProof` endpoint (#556). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.